Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new ElectrodesTable neurodata type #539

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from
Draft

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 28, 2023

Summary of changes

Need to get PyNWB and MatNWB to work with this first.

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.

If this is the first schema change after a schema release (i.e., the version string in core/nwb.namespace.yaml does not
end in "-alpha"), then:

  • Update the version string in core/nwb.namespace.yaml and core/nwb.file.yaml to the next major/minor/patch
    version with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
    new version string should be "2.5.0-alpha".
  • Update the value of the version variable in docs/format/source/conf.py to the next version without the
    suffix "-alpha", e.g., "2.5.0".
  • Update the value of the release variable in docs/format/source/conf.py to the next version with the suffix
    "-alpha", e.g., "2.5.0-alpha".
  • Add a new section in the release notes docs/format/source/format_release_notes.rst for the new version
    with the date "Upcoming" in parentheses.

@mavaylon1
Copy link
Contributor

mavaylon1 commented Mar 25, 2024

@rly I can push this across the finish line because I was going to work on literally this due to some applications in TermSetconfig.

The rest of the work would be working this on the pynwb side, is there a PR for it?

@rly rly added this to the 2.8.0 milestone Sep 19, 2024
@mavaylon1 mavaylon1 marked this pull request as ready for review October 2, 2024 00:27
core/nwb.ecephys.yaml Outdated Show resolved Hide resolved
@rly rly changed the title [WIP] Create new ElectrodesTable neurodata type Create new ElectrodesTable neurodata type Nov 19, 2024
@rly rly modified the milestones: 2.8.0, 2.9.0 Nov 19, 2024
@rly
Copy link
Contributor Author

rly commented Nov 19, 2024

Bumping to 2.9.0 release.
TODO:

  • Update version strings
  • Test with MatNWB
  • Test with PyNWB

@rly rly marked this pull request as draft November 19, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electrodes table and frequency bands table should be their own types
2 participants