Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device.model_number, model_name, serial_number #594

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Add Device.model_number, model_name, serial_number #594

merged 5 commits into from
Nov 8, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 8, 2024

Summary of changes

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
  • Make sure that hdmf-common-schema points to the latest release and not the latest commit on the main branch.

@stephprince
Copy link
Contributor

Will also fix #258

rly and others added 2 commits November 8, 2024 12:13
Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com>
@rly rly enabled auto-merge (squash) November 8, 2024 20:14
@rly rly merged commit 8f628dd into dev Nov 8, 2024
4 of 5 checks passed
@rly rly deleted the model_number branch November 8, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device model numbers
2 participants