add cell_id to IntracellularElectrode #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendichter
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1459 +/- ##
=======================================
Coverage 77.46% 77.47%
=======================================
Files 37 37
Lines 2734 2735 +1
Branches 455 455
=======================================
+ Hits 2118 2119 +1
Misses 535 535
Partials 81 81
Continue to review full report at Codecov.
|
oruebel
added
priority: high
|
Please add a roundtrip test, which will probably only work after the schema is updated. |
|
done. Should I update the nwb schema as well? |
|
Yes, please update the schema submodule to point to the head of nwb-schema. |
rly
approved these changes
Apr 29, 2022
|
@bendichter this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
relies on NeurodataWithoutBorders/nwb-schema#512