Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make electrode table a DynamicTable #634

Merged
merged 16 commits into from
Sep 28, 2018
Merged

Conversation

ajtritt
Copy link
Member

@ajtritt ajtritt commented Sep 28, 2018

Motivation

The ElectrodeTable required users to make an extension to add additional metadata about electrodes. Making the electrode table a DynamicTable will avoid the inevitable plethora of extensions for adding new electrode metadata.

Additionally, the compound dtype of the ElectrodeTable would require unpacking every row of the table to query on a single column, resulting in poor performance for querying along columns.

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ?

@ajtritt ajtritt added this to the NWB 2.0 Full milestone Sep 28, 2018
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #634 into dev will decrease coverage by 1.49%.
The diff coverage is 73.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #634     +/-   ##
=========================================
- Coverage   76.84%   75.35%   -1.5%     
=========================================
  Files          59       58      -1     
  Lines        6392     6479     +87     
  Branches     1270     1299     +29     
=========================================
- Hits         4912     4882     -30     
- Misses       1143     1242     +99     
- Partials      337      355     +18
Impacted Files Coverage Δ
src/pynwb/form/__init__.py 66.66% <100%> (-15.16%) ⬇️
src/pynwb/io/file.py 96.66% <100%> (ø) ⬆️
src/pynwb/ecephys.py 93.63% <100%> (-0.86%) ⬇️
src/pynwb/form/query.py 55.76% <100%> (+0.96%) ⬆️
src/pynwb/form/spec/spec.py 79.85% <27.27%> (-0.42%) ⬇️
src/pynwb/form/build/builders.py 88.4% <50%> (-2%) ⬇️
src/pynwb/form/backends/hdf5/h5tools.py 69.1% <71.42%> (-5.82%) ⬇️
src/pynwb/form/utils.py 88.33% <75%> (+0.09%) ⬆️
src/pynwb/core.py 71.29% <75%> (-1.19%) ⬇️
src/pynwb/form/build/map.py 76.96% <77.41%> (-2.12%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2108083...9eb9857. Read the comment docs.

@ajtritt ajtritt merged commit a3dd6e1 into dev Sep 28, 2018
@oruebel oruebel deleted the enh/electrodes_dynamic_table branch October 2, 2018 16:22
ajtritt referenced this pull request in NileGraddis/pynwb Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants