-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make electrode table a DynamicTable #634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap in for ElectrodeTableRegion
Codecov Report
@@ Coverage Diff @@
## dev #634 +/- ##
=========================================
- Coverage 76.84% 75.35% -1.5%
=========================================
Files 59 58 -1
Lines 6392 6479 +87
Branches 1270 1299 +29
=========================================
- Hits 4912 4882 -30
- Misses 1143 1242 +99
- Partials 337 355 +18
Continue to review full report at Codecov.
|
oruebel
approved these changes
Sep 28, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ElectrodeTable required users to make an extension to add additional metadata about electrodes. Making the electrode table a DynamicTable will avoid the inevitable plethora of extensions for adding new electrode metadata.
Additionally, the compound dtype of the ElectrodeTable would require unpacking every row of the table to query on a single column, resulting in poor performance for querying along columns.
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ?