Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Allen Visual Behavior notebooks #1112

Closed
wants to merge 1 commit into from
Closed

Updates to Allen Visual Behavior notebooks #1112

wants to merge 1 commit into from

Conversation

matchings
Copy link
Contributor

Updates to account for most recent version of AllenSDK which includes multiple stimulus blocks for each recording session. More info can be found under "data file changelog" here: https://allensdk.readthedocs.io/en/latest/visual_behavior_optical_physiology.html

Also a few additional references was added to the documentation in the markdown file for the Neurons page

@marius10p
Copy link
Collaborator

@iamzoltan do you know what this failed check means? We need this update as soon as possible so the Allen Institute projects can run.

@matchings
Copy link
Contributor Author

@iamzoltan Let me know if there is anything i can do to help troubleshoot the checks failing, or anything else to test and validate the changes to the notebooks that were part of this PR. I know its cutting it close to the start of the course, so I will be available most of today (July 7) to help.

@iamzoltan
Copy link
Contributor

iamzoltan commented Jul 8, 2024

@marius10p and @matchings yes this is cutting it very close to the course. Rushing like this is how things break. The process to make changes is as follows:

  • Make your changes in a forked repo
  • Create a PR to a staging branch
  • We review the changes
  • We then create a PR internally from the staging branch to the main branch.
  • If all checks and processing passes, we merge to main, if not, we ask you to make changes and create another PR
  • Once merged, we can build and publish the book

We will get this going as soon as possible.

p.s
Do not make direct commits to main

@yavorska-iryna
Copy link
Contributor

I can redo the steps.

@yavorska-iryna yavorska-iryna closed this by deleting the head repository Jul 8, 2024
@iamzoltan
Copy link
Contributor

@yavorska-iryna I called the staging branch allen-hot-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants