This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
iOS Universal Links and Android App Links #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@redreceipt @richarddubay One of yall should make sure to run tests. My local snaps are somehow messed up. |
Codecov Report
@@ Coverage Diff @@
## develop #229 +/- ##
==========================================
Coverage ? 44.94%
==========================================
Files ? 151
Lines ? 1395
Branches ? 141
==========================================
Hits ? 627
Misses ? 685
Partials ? 83
|
redreceipt
suggested changes
Aug 30, 2019
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
Nice work! Want to add a test for the new query and new data source function? |
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
redreceipt
suggested changes
Sep 1, 2019
packages/apollos-church-api/src/data/content-items/data-source.js
Outdated
Show resolved
Hide resolved
redreceipt
added
waiting for changes
PR needs some changes
and removed
ready for review
This is ready to be reviewd
labels
Sep 1, 2019
…ject into new-universal-links
cdanwards
added
ready for review
This is ready to be reviewd
and removed
waiting for changes
PR needs some changes
labels
Sep 5, 2019
redreceipt
approved these changes
Sep 5, 2019
richarddubay
approved these changes
Sep 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
What does this PR do, or why is it needed?
This PR adds the native code, id parser and linking handling for ios universal links and android app links.
This allows phones that have the app downloaded to point a
newspring.cc
link to that piece of content in the app.The corresponding association files for the website can be found at:
How do I test this PR?
Load an android sim and run:
adb shell am start -W -a android.intent.action.VIEW -d "https://newspring.cc/articles/how-to-help-your-young-adult-manage-money-wisely
Load an apple sim and run:
xcrun simctl openurl booted https://newspring.cc/articles/how-to-help-your-young-adult-manage-money-wisely
TODO
REVIEW
Manual QA