Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

iOS Universal Links and Android App Links #229

Merged
merged 37 commits into from
Sep 5, 2019
Merged

Conversation

cdanwards
Copy link
Contributor

DESCRIPTION

What does this PR do, or why is it needed?

This PR adds the native code, id parser and linking handling for ios universal links and android app links.

This allows phones that have the app downloaded to point a newspring.cc link to that piece of content in the app.

The corresponding association files for the website can be found at:

newspring.cc/.well-known/assetlink.json
newspring.cc/apple-app-site-association

How do I test this PR?

Load an android sim and run:
adb shell am start -W -a android.intent.action.VIEW -d "https://newspring.cc/articles/how-to-help-your-young-adult-manage-money-wisely
Load an apple sim and run:
xcrun simctl openurl booted https://newspring.cc/articles/how-to-help-your-young-adult-manage-money-wisely

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@cdanwards cdanwards added the ready for review This is ready to be reviewd label Aug 30, 2019
@cdanwards
Copy link
Contributor Author

@redreceipt @richarddubay One of yall should make sure to run tests. My local snaps are somehow messed up.

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@039fe3f). Click here to learn what that means.
The diff coverage is 37.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #229   +/-   ##
==========================================
  Coverage           ?   44.94%           
==========================================
  Files              ?      151           
  Lines              ?     1395           
  Branches           ?      141           
==========================================
  Hits               ?      627           
  Misses             ?      685           
  Partials           ?       83
Impacted Files Coverage Δ
packages/newspringchurchapp/src/Providers.js 50% <ø> (ø)
...s-church-api/src/data/content-items/data-source.js 33.96% <0%> (ø)
...llos-church-api/src/data/content-items/resolver.js 57.14% <0%> (ø)
...ackages/newspringchurchapp/src/linking/Provider.js 43.47% <43.47%> (ø)

@redreceipt
Copy link
Contributor

Nice work! Want to add a test for the new query and new data source function?

Daniel Edwards and others added 9 commits September 1, 2019 09:02
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
Co-Authored-By: Michael Neeley <micneeley14@gmail.com>
@redreceipt redreceipt added waiting for changes PR needs some changes and removed ready for review This is ready to be reviewd labels Sep 1, 2019
@cdanwards cdanwards added ready for review This is ready to be reviewd and removed waiting for changes PR needs some changes labels Sep 5, 2019
Copy link
Member

@richarddubay richarddubay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@redreceipt redreceipt merged commit b9eaa03 into develop Sep 5, 2019
@redreceipt redreceipt deleted the new-universal-links branch September 5, 2019 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review This is ready to be reviewd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants