Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behaviours for choice elements #18

Closed
2 of 3 tasks
tiagosousagarcia opened this issue Apr 11, 2024 · 0 comments · Fixed by #22
Closed
2 of 3 tasks

Add behaviours for choice elements #18

tiagosousagarcia opened this issue Apr 11, 2024 · 0 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request

Comments

@tiagosousagarcia
Copy link
Collaborator

tiagosousagarcia commented Apr 11, 2024

Summary

Currently encountered a few <choice> elements (so far all with abbreviations) -- add options and behaviours to:

  • Only display one or the other
  • Display both
  • Add typographic conventions for expansion

What needs to be done?

  • Define behaviour
  • Create options
  • Write docs

Updates

20240523 -- Corrected recursion problems and fixed other issues. TODO: documentation, tests; URGENT TODO: PR #21 Seems to have accidentally removed all behaviours for <orgName> -- Need to fix this. THIS IS WHY WE NEED AUTO TESTING! 😩
20240517 -- Finished draft behaviours for choice elements, separating between corrections and abbreviations. Inline markers work well; events also work but the behaviour is being called twice (once before anything, another after the expanded has been removed) -- need to fix this; also add documentation, test, and cover edge cases.

@tiagosousagarcia tiagosousagarcia added the enhancement New feature or request label Apr 11, 2024
@tiagosousagarcia tiagosousagarcia self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant