Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiagosousagarcia/issue18 #22

Merged
merged 6 commits into from
May 24, 2024
Merged

Tiagosousagarcia/issue18 #22

merged 6 commits into from
May 24, 2024

Conversation

tiagosousagarcia
Copy link
Collaborator

Description

Adds options and behaviours for <choice> elements; corrects a bug introduced by the previous PR on orgName events; makes all events bubble by default (for allow for nesting of choices and org/pers names);

Fixes #18

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Manually tested

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

What should reviewers look for?

Please provide any specific areas of feedback you're looking for from reviewers.

@tiagosousagarcia tiagosousagarcia merged commit 050cb05 into dev May 24, 2024
1 check passed
@tiagosousagarcia tiagosousagarcia deleted the tiagosousagarcia/issue18 branch May 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add behaviours for choice elements
1 participant