Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiagosousagarcia/issue26 #36

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Tiagosousagarcia/issue26 #36

merged 3 commits into from
Jun 7, 2024

Conversation

tiagosousagarcia
Copy link
Collaborator

Description

Adds behaviour and documentation for deletions; also corrects an error in the index.html test file

Fixes #26 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Manual testing

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

What should reviewers look for?

Please provide any specific areas of feedback you're looking for from reviewers.

@tiagosousagarcia tiagosousagarcia merged commit cc531cd into dev Jun 7, 2024
1 check passed
@tiagosousagarcia tiagosousagarcia deleted the tiagosousagarcia/issue26 branch June 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour for <del>
1 participant