Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libheif build #42

Merged
merged 12 commits into from
Sep 18, 2023
Merged

Fix libheif build #42

merged 12 commits into from
Sep 18, 2023

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    bf75aa5 View commit details
    Browse the repository at this point in the history
  2. Disable unnecessary extras

    Per John Cupitt, these are not necessary
    
    #41 (comment)
    brandoncc committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    3af8c48 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Build without modules

    brandoncc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    fc62dfe View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    f67a062 View commit details
    Browse the repository at this point in the history
  2. Switch back to poppler from pdfium

    John Cuppit (libvips creator and maintainer) found issues with the
    heroku-built libheif and the compiled version of pdfium. He recommended
    switching back to poppler as a result.
    
    #41 (comment)
    #41 (comment)
    brandoncc committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    5dbbdcf View commit details
    Browse the repository at this point in the history
  3. Switch to stack-specific build files, switch back to poppler from pdfium

    The stacks are getting more and more native libraries that we depend on
    installed by Heroku. This allows us to remove them from our build and
    just include the -dev packages that match the runtime packages that
    Heroku installed.
    brandoncc committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    c010f98 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dda6502 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a3ef14b View commit details
    Browse the repository at this point in the history
  6. Remove imagemagick, which removes ico/bmp support

    One of the drivers of Rails switching to libvips was the security risks
    posed by imagemagick. It would be better if we don't add that risk back
    to Rails apps by including it in the libvips build.
    brandoncc committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    168f70f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f68f2bc View commit details
    Browse the repository at this point in the history
  8. Update build

    brandoncc committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    a12bf10 View commit details
    Browse the repository at this point in the history
  9. Add a changelog

    brandoncc committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b788e22 View commit details
    Browse the repository at this point in the history