-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix libheif build #42
Merged
Merged
Commits on Sep 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bf75aa5 - Browse repository at this point
Copy the full SHA bf75aa5View commit details -
Per John Cupitt, these are not necessary #41 (comment)
Configuration menu - View commit details
-
Copy full SHA for 3af8c48 - Browse repository at this point
Copy the full SHA 3af8c48View commit details
Commits on Sep 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fc62dfe - Browse repository at this point
Copy the full SHA fc62dfeView commit details
Commits on Sep 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f67a062 - Browse repository at this point
Copy the full SHA f67a062View commit details -
Switch back to poppler from pdfium
John Cuppit (libvips creator and maintainer) found issues with the heroku-built libheif and the compiled version of pdfium. He recommended switching back to poppler as a result. #41 (comment) #41 (comment)
Configuration menu - View commit details
-
Copy full SHA for 5dbbdcf - Browse repository at this point
Copy the full SHA 5dbbdcfView commit details -
Switch to stack-specific build files, switch back to poppler from pdfium
The stacks are getting more and more native libraries that we depend on installed by Heroku. This allows us to remove them from our build and just include the -dev packages that match the runtime packages that Heroku installed.
Configuration menu - View commit details
-
Copy full SHA for c010f98 - Browse repository at this point
Copy the full SHA c010f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for dda6502 - Browse repository at this point
Copy the full SHA dda6502View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3ef14b - Browse repository at this point
Copy the full SHA a3ef14bView commit details -
Remove imagemagick, which removes ico/bmp support
One of the drivers of Rails switching to libvips was the security risks posed by imagemagick. It would be better if we don't add that risk back to Rails apps by including it in the libvips build.
Configuration menu - View commit details
-
Copy full SHA for 168f70f - Browse repository at this point
Copy the full SHA 168f70fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f68f2bc - Browse repository at this point
Copy the full SHA f68f2bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a12bf10 - Browse repository at this point
Copy the full SHA a12bf10View commit details -
Configuration menu - View commit details
-
Copy full SHA for b788e22 - Browse repository at this point
Copy the full SHA b788e22View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.