Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Fix widget sometimes MemCrash on exit. #103

Merged
merged 1 commit into from
Apr 20, 2024
Merged

JS: Fix widget sometimes MemCrash on exit. #103

merged 1 commit into from
Apr 20, 2024
+2 −2

Conversation

jamisonderek
Copy link
Contributor

@jamisonderek jamisonderek commented Apr 19, 2024 •
edited by Willy-JL
Loading

What's new

  • Bug fix where sometimes JavaScript scripts were crashing on exit if they used the JS widget feature.

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Willy-JL
Willy-JL approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Willy-JL Willy-JL added the bugfix Something isn't working label Apr 20, 2024
@Willy-JL Willy-JL merged commit f2a6ad6 into Next-Flip:dev Apr 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@jamisonderek jamisonderek

Labels
bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamisonderek @Willy-JL