Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC: Improve URI decoding in NDEF parser #267

Merged
merged 8 commits into from
Oct 20, 2024
Merged

NFC: Improve URI decoding in NDEF parser #267

merged 8 commits into from
Oct 20, 2024

Conversation

jaylikesbunda
Copy link
Contributor

@jaylikesbunda jaylikesbunda commented Oct 14, 2024 •
edited by Willy-JL
Loading

What's new

  • New decode_char function for hex to ASCII conversion
  • Updated parse_ndef_uri with decoding step
  • Increased buffer sizes to prevent overflows
  • Added memory allocation checks

Screenshot-20241015-060628

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@jaylikesbunda jaylikesbunda changed the title Improve URI decoding in NDEF parser [NFC] Improve URI decoding in NDEF parser Oct 14, 2024
Willy-JL
Willy-JL requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can get those patched up :D

applications/main/nfc/plugins/supported_cards/ndef.c Outdated Show resolved Hide resolved
applications/main/nfc/plugins/supported_cards/ndef.c Outdated Show resolved Hide resolved
applications/main/nfc/plugins/supported_cards/ndef.c Outdated Show resolved Hide resolved
applications/main/nfc/plugins/supported_cards/ndef.c Outdated Show resolved Hide resolved
applications/main/nfc/plugins/supported_cards/ndef.c Outdated Show resolved Hide resolved
applications/main/nfc/plugins/supported_cards/ndef.c Outdated Show resolved Hide resolved
@Willy-JL Willy-JL changed the title [NFC] Improve URI decoding in NDEF parser NFC: Improve URI decoding in NDEF parser Oct 20, 2024
@Willy-JL Willy-JL added the enhancement New enhancement or request label Oct 20, 2024
Willy-JL and others added 2 commits October 20, 2024 05:34
@Willy-JL
Update changelog
0dd71de
@Willy-JL @jaylikesbunda
Clearer code for hex decode
5e5fc41 
Co-authored-by: jaylikesbunda <jaylikesbunda@users.noreply.github.com>
@Willy-JL Willy-JL merged commit 7ebbadf into Next-Flip:dev Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@jaylikesbunda jaylikesbunda

Labels
enhancement New enhancement or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaylikesbunda @Willy-JL