[CAT-162] Feature: Splash 구현 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devMinseok
previously approved these changes
Aug 9, 2024
| private func login(deviceID: String) -> Effect<Action> { | ||
| return .run { send in | ||
| let response = try await authService.login(deviceID: deviceID, apiClient: apiClient) | ||
| _ = keychainClient.create(key: KeychainKeys.accessToken.rawValue, data: response.accessToken) |
There was a problem hiding this comment.
KeychainClient를 직접사용하지 않고 AuthService에서 사용하면 어떨까?
로그인 후 response를 받고 데이터를 저장하는것 까지 도메인에서 처리하는거지
There was a problem hiding this comment.
흠 그렇게 되면 authservice의 login()이 apiclient, keychianclient 두개를 모두 받는거구나
사용하지 않는 모듈 머가 있지 ?? AppFeature 이거 삭제해도 되는건가 ? |
Example, Tests, Testing 이런모듈타겟들은 사용안하면 그냥 제거 해줘! (ex: SplashExample) |
devMinseok
requested changes
Aug 10, 2024
Jihyun247
force-pushed
the
feature/CAT-162
branch
from
fe32695
to
0ab4198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CAT-162] Feature: Splash 구현
무엇에 관한 PR 인가요? 🙋
Splash 기능 구현
어떤 것을 작업하셨나요? 🛠
🌱 PR Point
위 3번의 이동 뷰 결정 로직 입니닷
1 디바이스 아이디가 키체인에 있는지 확인
--1-1 있다면 존재하는 토큰이 키체인에 있는지 확인
----1-1-1 있다면 유저디폴트에서 온보딩 끝냄 여부 확인
------1-1-1-1 끝냈다면 홈뷰로 이동
------1-1-1-2 안끝냈다면 온보딩뷰로 이동
----1-1-2 없다면 login()
--1-2 없다면 디바이스 아이디 발급, 키체인 저장 후 -> login()
디바이스 아이디가 매개변수인 login() 메서드
구현: 발급된 디바이스 아이디로 /tokens 로그인 -> 발급받은 token 키체인 저장 -> 온보딩 뷰로 이동