-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAT-208] 온보딩 - 고양이 이름짓기 뷰 UI 및 로직 #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
툴팁 안뜨는건 앱한번 지워도 안되는건가? |
이거 온보딩 시작했다가(최초 로그인) 앱지우고 다시 설치하고 실행했을때 또 온보딩으로 가네? |
오대박 온보딩 끝내면 온보딩유무값 변경해주는거 빼먹었다 |
온보딩유무값 변경하는거 적용하면서 함 해볼게 나두~ |
devMinseok
requested changes
Aug 17, 2024
Projects/Feature/OnboardingFeature/Sources/NamingCat/NamingCatError.swift
Outdated
Show resolved
Hide resolved
Projects/Feature/OnboardingFeature/Sources/NamingCat/NamingCatView.swift
Outdated
Show resolved
Hide resolved
Projects/Feature/OnboardingFeature/Sources/Onboarding/OnboardingView.swift
Outdated
Show resolved
Hide resolved
추가로 혹시 온보딩에서 홈화면으로 전환할때 transition 애니메이션 효과를 주면 어떨까? // AppView.swift
Group {
if let splashStore = store.scope(state: \.splash, action: \.splash) {
SplashView(store: splashStore)
} else if let homeStore = store.scope(state: \.home, action: \.home) {
HomeView(store: homeStore)
} else if let onboardingStore = store.scope(state: \.onboarding, action: \.onboarding) {
OnboardingView(store: onboardingStore)
} else {
Color.red
}
}
.transition(.opacity) // <- transition 효과적용
.onAppear {
store.send(.onAppear)
} |
옹 적용했다 ! 아 그리구 앱 지웠다가 다시 실행하니까 온보딩->홈 넘어갈때 dimmed 툴팁들 잘 뜬다 !! 이유가 머야 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CAT-208] 온보딩 - 고양이 이름짓기 뷰 UI 및 로직
무엇에 관한 PR 인가요? 🙋
고양이 이름짓기 뷰 UI 및 로직
🌱 PR Point
-> Onboarding의 .onAppear action을 NavigationStack에 달아준것이 아닌, NavigationStack 내부에 달아주어서 Onboarding.Action.onAppear가 호출되었던 것 같아요