Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-47] KeychainClient 모듈 추가 #9

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Conversation

devMinseok
Copy link
Member

@devMinseok devMinseok commented Jul 20, 2024

어떤 것을 작업하셨나요? 🛠

  • Tuist 모듈 구조 개선
    • Feature, Domain, Core, Shared 부모 모듈 및 자식 모듈 그룹핑
  • KeychainClient 모듈 추가

🌱 PR Point

  • 모듈 생성시 의존성을 TargetType별로 넣을 수 있도록 개선
  • 각 모듈 레이어를 추상적으로 가지게 하려 했으나 dynamicFramework로 그룹화 할 수 있도록 변경
  • KeychainClient 모듈 추가하면서 테스트 코드 아주 간단하게 추가

@devMinseok devMinseok added the enhancement New feature or request label Jul 20, 2024
@devMinseok devMinseok self-assigned this Jul 20, 2024
Copy link

linear bot commented Jul 20, 2024

Jihyun247
Jihyun247 previously approved these changes Jul 20, 2024
@@ -10,22 +10,23 @@ import UtilityPlugin
import DependencyPlugin

extension Project {
public static func project<T: Modulable>(
public static func makeTMABasedProject<T: Modulable>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 프로젝트 생성 메서드 이름을 makeTMABasedProject 로 바꿨네용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞습니당~ TMA기반 프로젝트 생성용이쥬

@devMinseok
Copy link
Member Author

devMinseok commented Jul 20, 2024

모델은 Domain 모듈에서 각자 관리하도록 강제하기 위해서 Model 모듈을 제거 했습니다~

@devMinseok
Copy link
Member Author

develop 브랜치 업데이트 되어서 rebase(+ force-pushed) 후 병합진행

@devMinseok devMinseok merged commit 9269c57 into develop Jul 20, 2024
1 check passed
@devMinseok devMinseok deleted the feature/CAT-47 branch July 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants