Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Backtab and Shift-Tab for hovering selection backwards #691

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

resolritter
Copy link
Contributor

closes #690

@deepbluev7
Copy link
Member

Awesome! Would you mind also adding that to the MessageInput, or would you rather just add those 2? You probably just need to add the shift check here: https://github.com/Nheko-Reborn/nheko/blob/master/resources/qml/MessageInput.qml#L198

@resolritter
Copy link
Contributor Author

Awesome! Would you mind also adding that to the MessageInput

Done. Sorry I missed it the first time.

@deepbluev7
Copy link
Member

No worries, thanks for implementing this! I'll test it locally and then this should be good to merge. Thanks a lot!

@deepbluev7
Copy link
Member

Seems to work great, thanks a lot!

@deepbluev7 deepbluev7 merged commit c0da89d into Nheko-Reborn:master Aug 22, 2021
@resolritter resolritter deleted the hover branch August 23, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hovering list items backwards with Shift-Tab
2 participants