Skip to content

Commit

Permalink
change docker config to use 8 characters length password for NEO4J_AUTH
Browse files Browse the repository at this point in the history
use hello-word image for service_healthy check instead of busybox
update unit tests with new password
  • Loading branch information
Popotojs committed Jan 5, 2023
1 parent 027004f commit 68f658e
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ services:
- "7687:7687"
environment:
- NEO4J_ACCEPT_LICENSE_AGREEMENT=yes
- NEO4J_AUTH=neo4j/test
- NEO4J_AUTH=neo4j/test_password
# Raise memory limits
- NEO4J_server_memory_pagecache_size=1G
- NEO4J_server.memory.heap.initial_size=1G
Expand All @@ -22,8 +22,8 @@ services:
retries: 20
start_period: 40s

busybox:
image: 'busybox:stable'
hello-word:
image: 'hello-world'
depends_on:
neo4j:
condition: service_healthy
2 changes: 1 addition & 1 deletion spec/e2e/.test.env
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ NEO4J_SCHEME=neo4j
NEO4J_PORT=7687
NEO4J_HOST=localhost
NEO4J_USERNAME=neo4j
NEO4J_PASSWORD=test
NEO4J_PASSWORD=test_password
2 changes: 1 addition & 1 deletion spec/e2e/src/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { CatsModule } from './cat/cats.module';
port: '7687',
database: 'neo4j',
username: 'neo4j',
password: 'test',
password: 'test_password',
global: true,
}),
CatsModule,
Expand Down
2 changes: 1 addition & 1 deletion spec/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export async function createNeo4jTestingModule() {
port: '7687',
database: 'neo4j',
username: 'neo4j',
password: 'test',
password: 'test_password',
}),
],
}).compile();
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/service/neo4j-service-.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Neo4jService', () => {
expect(await app.neo4jService.verifyConnectivity()).toMatchInlineSnapshot(`
ServerInfo {
"address": "localhost:7687",
"agent": "Neo4j/5.2.0",
"agent": "Neo4j/5.3.0",
"protocolVersion": 5,
}
`);
Expand Down

0 comments on commit 68f658e

Please sign in to comment.