Deprecation warnings and JADE fix #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning has been fixed by using the .tolist() function in order for the comparison to be between native Python objects
Deprecation warnings have been fixed, using dtype for needed arrays
JADE algorithm has been fixed during the test warning fixing stage. It seems that the CrossRandCurr2Pbest function needed a rework, as the third parameter was misused, it needed to be the function evaluations for the population
Fixed test warnings for ASO method, there was the need of specifying dtype
|
Brilliant! Thank you @sisco0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned at #297 it happens that some warnings are thrown when running tests. These warnings are referred to
dtypespecification whenasarrayfunction is invoked.It could be seen that the JADE method was not correctly sanitized, as the third parameter should be replaced in order to correctly perform the operations present in its related research paper.
Other Information
I would like to thank @zStupan for the support at creating this Pull Request, where he aided me at solving some debugging issue that was happening for ASO test cases and the
-W errorpytest parameter.