Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed scipy dependency #304

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Removed scipy dependency #304

merged 3 commits into from
Apr 21, 2021

Conversation

zStupan
Copy link
Contributor

@zStupan zStupan commented Apr 21, 2021

Implemented all the changes discussed in #303, as well as:

  • Removed all other python2 backwards compatibility libraries from dev dependencies
  • Removed __future__ imports
  • Fixed some typos in the readme's

@firefly-cpp
Copy link
Contributor

Thanks @zStupan

You can not imagine how much your help is appreciated :)

@firefly-cpp
Copy link
Contributor

One remark

Have you already compared the results obtained by the new implementation against the previous one?

@firefly-cpp
Copy link
Contributor

Anyway, merging PR to master.

@firefly-cpp firefly-cpp merged commit ae491b4 into NiaOrg:master Apr 21, 2021
@zStupan
Copy link
Contributor Author

zStupan commented Apr 21, 2021

Only the results in cuckoo search are slightly different, because I used an approximate numerical method, but it's the same method used in the MATLAB code of the original author of the algorithm. Scipy uses a different method.

@firefly-cpp firefly-cpp mentioned this pull request Apr 21, 2021
@zStupan zStupan deleted the remove_scipy_dep branch April 21, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants