refactor: fix lint issues for unittests

ci: fix workflows
lint: add .golangci.yml

.github/workflows/codeql.yml

@@ -35,10 +35,17 @@ jobs:
                 category: "/language:go"
 
     lint:
+        name: Lint
         runs-on: ubuntu-latest
+        needs: codeql
         steps:
-          - uses: actions/checkout@v4
-          - uses: actions/setup-go@v5
+          - name: Checkout Repo
+            uses: actions/checkout@v4
+
+          - name: Setup Go
+            uses: actions/setup-go@v5
             with:
                 go-version: 1.23
-          - uses: golangci/golangci-lint-action@v3
+
+          - name: GolangCI Lint
+            uses: golangci/golangci-lint-action@v3

.github/workflows/docker.yml

@@ -15,7 +15,7 @@ jobs:
             github.actor != 'dependabot[bot]' &&
             github.actor != 'github-actions[bot]' &&
             github.actor != 'protected-auto-commits[bot]'
-        name: Packages
+        name: Docker Images
         runs-on: ubuntu-latest
         permissions:
             contents: read
@@ -34,6 +34,7 @@ jobs:
           - name: Checkout Repo
             uses: actions/checkout@v4
             with:
+                fetch-depth: 0
                 token: ${{ steps.app-token.outputs.token }}
 
           - name: Set up Docker Buildx
@@ -57,8 +58,8 @@ jobs:
             uses: docker/metadata-action@v5
             with:
                 images: |
-                    ${{ vars.DOCKER_USERNAME }}/${{ github.repository }}
-                    ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}
+                    ${{ vars.DOCKER_USERNAME }}/automatedgo
+                    ghcr.io/${{ github.repository_owner }}/AutomatedGo
                 tags: |
                     type=semver,pattern={{version}}
                     type=ref,event=branch,pattern={{branch}}
@@ -76,9 +77,9 @@ jobs:
                 secrets: |
                     GITHUB_TOKEN=${{ steps.app-token.outputs.token }}
 
-          - name: Generate artifact attestation
+          - name: Generate Artifact Attestation
             uses: actions/attest-build-provenance@v1
             with:
-                subject-name: ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}
+                subject-name: ghcr.io/${{ github.repository_owner }}/AutomatedGo
                 subject-digest: ${{ steps.push.outputs.digest }}
                 push-to-registry: true

.github/workflows/release.yml

@@ -80,7 +80,7 @@ jobs:
           - name: Fetch latest tags
             run: git fetch --force --tags
 
-          - name: Set up Go
+          - name: Setup Go
             uses: actions/setup-go@v5
             with:
                 go-version: "1.22.x"

.golangci.yml

@@ -0,0 +1,9 @@
+run:
+    timeout: 1m
+output:
+    formats:
+        - format: colored-line-number
+          path: stdout
+linters:
+    enable:
+        - errcheck

tests/unit/checker_test.go

@@ -22,7 +22,9 @@ func resetTestVersionURL() {
 func TestGetLatestVersion(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("go1.17.1\n"))
+		if _, err := w.Write([]byte("go1.17.1\n")); err != nil {
+			t.Fatalf("Failed to write response: %v", err)
+		}
 	}))
 	defer server.Close()
 
@@ -66,7 +68,9 @@ func TestGetLatestVersionReadError(t *testing.T) {
 func TestGetLatestVersionMalformedResponse(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("malformed\nresponse\n"))
+		if _, err := w.Write([]byte("malformed\nresponse\n")); err != nil {
+			t.Fatalf("Failed to write response: %v", err)
+		}
 	}))
 	defer server.Close()
 

tests/unit/checksum_test.go

@@ -39,7 +39,9 @@ func TestGetOfficialChecksum(t *testing.T) {
 						},
 					},
 				}
-				json.NewEncoder(w).Encode(releases)
+				if err := json.NewEncoder(w).Encode(releases); err != nil {
+					t.Fatalf("Failed to encode JSON: %v", err)
+				}
 			},
 			filename: "go1.22.5.linux-amd64.tar.gz",
 			want:     "904b924d435eaea086515bc63235b192ea441bd8c9b198c507e85009e6e4c7f0",
@@ -65,7 +67,9 @@ func TestGetOfficialChecksum(t *testing.T) {
 						},
 					},
 				}
-				json.NewEncoder(w).Encode(releases)
+				if err := json.NewEncoder(w).Encode(releases); err != nil {
+					t.Fatalf("Failed to encode JSON: %v", err)
+				}
 			},
 			filename: "go1.22.5.linux-amd64.tar.gz",
 			want:     "904b924d435eaea086515bc63235b192ea441bd8c9b198c507e85009e6e4c7f0",
@@ -91,7 +95,9 @@ func TestGetOfficialChecksum(t *testing.T) {
 						},
 					},
 				}
-				json.NewEncoder(w).Encode(releases)
+				if err := json.NewEncoder(w).Encode(releases); err != nil {
+					t.Fatalf("Failed to encode JSON: %v", err)
+				}
 			},
 			filename: "invalid.tar.gz",
 			want:     "",
@@ -127,7 +133,9 @@ func TestGetOfficialChecksum(t *testing.T) {
 		{
 			name: "Invalid JSON",
 			serverFunc: func(w http.ResponseWriter, r *http.Request) {
-				w.Write([]byte("invalid json"))
+				if _, err := w.Write([]byte("invalid json")); err != nil {
+					t.Fatalf("Failed to write invalid JSON: %v", err)
+				}
 			},
 			filename: "go1.22.5.linux-amd64.tar.gz",
 			want:     "",

tests/unit/downloader_test.go

@@ -17,7 +17,9 @@ func TestDownloadFile(t *testing.T) {
 	// Create a test server
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("test content"))
+		if _, err := w.Write([]byte("test content")); err != nil {
+			t.Fatalf("Failed to write response: %v", err)
+		}
 	}))
 	defer server.Close()