feat: change scopes for replay downloading (#256)

* feat: change scopes for replay downloading * feat: update tests
NiceAesth · Nov 16, 2024 · ec34f23 · ec34f23
1 parent 0b1f2d2
commit ec34f23
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 6 deletions.
diff --git a/aiosu/v2/client.py b/aiosu/v2/client.py
@@ -1819,16 +1819,15 @@ async def get_score_lazer(
     @prepare_token
     @check_token
     @requires_scope(Scopes.PUBLIC)
-    @requires_scope(Scopes.IDENTIFY | Scopes.DELEGATE, any_scope=True)
     async def get_score_replay(
         self,
-        score_id: int,
+        legacy_score_id: int,
         mode: Gamemode,
     ) -> BytesIO:
         r"""Gets the replay file for a score.
 
-        :param score_id: The ID of the score
-        :type score_id: int
+        :param legacy_score_id: The ID of the score
+        :type legacy_score_id: int
         :param mode: The gamemode to search for
         :type mode: aiosu.models.gamemode.Gamemode
 
@@ -1837,7 +1836,27 @@ async def get_score_replay(
         :return: Replay file
         :rtype: io.BytesIO
         """
-        url = f"{self.base_url}/api/v2/scores/{mode}/{score_id}/download"
+        url = f"{self.base_url}/api/v2/scores/{mode}/{legacy_score_id}/download"
+        return await self._request("GET", url)
+
+    @prepare_token
+    @check_token
+    @requires_scope(Scopes.PUBLIC)
+    async def get_score_replay_lazer(
+        self,
+        score_id: int,
+    ) -> BytesIO:
+        r"""Gets the replay file for a score.
+
+        :param score_id: The ID of the score
+        :type score_id: int
+
+        :raises APIException: Contains status code and error message
+        :raises RefreshTokenExpiredError: If the client refresh token has expired
+        :return: Replay file
+        :rtype: io.BytesIO
+        """
+        url = f"{self.base_url}/api/v2/scores/{score_id}/download"
         return await self._request("GET", url)
 
     @prepare_token

diff --git a/tests/data/v2/get_score_replay_lazer_200.osr b/tests/data/v2/get_score_replay_lazer_200.osr
diff --git a/tests/data/v2/get_score_replay_lazer_404.json b/tests/data/v2/get_score_replay_lazer_404.json
@@ -0,0 +1 @@
+{"error":"Specified Score\\Best\\Osu couldn't be found."}
diff --git a/tests/generate/main.py b/tests/generate/main.py
@@ -551,6 +551,17 @@ def _register_routes(self) -> None:
             f"{DATA_DIR}/v2/get_score_replay_404.json",
             expect_status=404,
         )
+        self._register_route(
+            "GET",
+            f"{BASE_URL}/api/v2/scores/1581778626/download",
+            f"{DATA_DIR}/v2/get_score_replay_lazer_200.osr",
+        )
+        self._register_route(
+            "GET",
+            f"{BASE_URL}/api/v2/scores/0/download",
+            f"{DATA_DIR}/v2/get_score_replay_lazer_404.json",
+            expect_status=404,
+        )
         self._register_route(
             "GET",
             f"{BASE_URL}/api/v2/rankings/osu/performance",

diff --git a/tests/test_v2/test_client.py b/tests/test_v2/test_client.py
@@ -244,7 +244,12 @@ async def test_generated(status_code, content_type, token, mocker):
     generate_test(
         aiosu.v2.Client.get_score_replay,
         STATUS_CAN_404_OCTET,
-        func_kwargs={"score_id": 4220635589, "mode": "osu"},
+        func_kwargs={"legacy_score_id": 4220635589, "mode": "osu"},
+    ),
+    generate_test(
+        aiosu.v2.Client.get_score_replay_lazer,
+        STATUS_CAN_404_OCTET,
+        func_kwargs={"score_id": 1581778626},
     ),
     generate_test(
         aiosu.v2.Client.get_rankings,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		{"error":"Specified Score\\Best\\Osu couldn't be found."}