fix: Update functions and strings for IE compat #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works in SB 5 as well |
NicholasBoll
approved these changes
Nov 12, 2020
|
Published in |
NicholasBoll
pushed a commit
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes a few months ago introduced arrow functions and template literals to
react.js. Storybook 6's default webpack/babel config no longer transpiles this package. Since this file is not transpiled before publishing, this causes errors in IE when importing in the preview iframe.This PR replaces arrow functions for regular functions and template literals for string concatenation.
✅ Verified that this works in Storybook 6.0.28