fix(create-turbo): correct package manager selection (vercel#4574)

NicholasLYang · Apr 21, 2023 · fb10c29 · fb10c29
1 parent 1f2b703
commit fb10c29
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/packages/create-turbo/src/commands/create/prompts.ts b/packages/create-turbo/src/commands/create/prompts.ts
@@ -100,9 +100,12 @@ export async function packageManager({
     choices: ["npm", "pnpm", "yarn"].map((p) => ({
       name: p,
       value: p,
-      disabled: availablePackageManagers?.[p as PackageManager]?.available
-        ? false
-        : `not installed`,
+      // npm should always be available
+      disabled:
+        p !== "npm" ||
+        availablePackageManagers?.[p as PackageManager]?.available
+          ? false
+          : `not installed`,
     })),
   });
 

diff --git a/packages/turbo-utils/src/managers.ts b/packages/turbo-utils/src/managers.ts
@@ -15,15 +15,21 @@ async function getVersion(
     env: { COREPACK_ENABLE_STRICT: "0" },
   };
 
+  let available = false;
   try {
+    const userAgent = process.env.npm_config_user_agent;
+    if (userAgent && userAgent.startsWith(packageManager)) {
+      available = true;
+    }
+
     const result = await execa(packageManager, ["--version"], execOptions);
     return {
       available: true,
       version: result.stdout.trim(),
     };
   } catch (e) {
     return {
-      available: false,
+      available,
     };
   }
 }