Change order of slicing when using _subdiagrams in Parallel calls, minor style changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issues/PRs
giotto-ai#428
Description
When reviewing your PR, I noticed that we are being inefficient with our calls to
_subdiagramsin the context of calls toParallelwhen slices are used. It is slightly more efficient to first sliceX, and then call_subdiagramson each slice to extract the subdiagrams (_subdiagramsalways copies data over). Would you be happy to sneak this into giotto-ai#428? I also made a couple of other tiny changes (useleninstead of.shape[0], a small improvement inplot_diagram) in passing.