improved collection of failed specs #1
Conversation
regex now matches lazy (using '?' after '*' in group) instead of greedy avoiding the need for result slicing and potential problems with multidigit line numbers failed specs only get added once (especially important when using multiCapabilities)
|
|
||
| export default function (output = '') { | ||
| // this could all probably fit into one regex... | ||
| var failedSpecLines = output.match(FAILED_LINE); | ||
| var output = arguments.length <= 0 || arguments[0] === undefined ? '' : arguments[0]; |
There was a problem hiding this comment.
Is there a need for this? output should always just be a giant blob of text (although perhaps it is different for multi capabilities?)
There was a problem hiding this comment.
This was actually copy&pasted from the code that npm install protractor-flake delivered. Otherwise I agree that it's not necessary.
|
This is great! Would it be possible to include some additional test coverage that parses multiCapabilities fixture text? |
| @@ -1,13 +1,15 @@ | |||
| const FAILED_LINE = /at \[object Object\]\.<anonymous> \((.*)\)/g; | |||
| const FAILED_LINES = /at \[object Object\]\.<anonymous> \((.*?):.*\)/g; | |||
There was a problem hiding this comment.
We should define this as a non-constant within the body of the function, since exec modifies the state of the regex it is invoked on.
|
I did a draft of a version that uses export default function (output = '') {
let match = null;
let FAILED_LINES = /at \[object Object\]\.<anonymous> \((.*?):.*\)/g;
let failedSpecs = new Set();
while (match = FAILED_LINES.exec(output)) {
failedSpecs.add(match[1]);
}
return [...failedSpecs];
} |
|
looks good to me as long as Set works as intended. |
|
I went ahead and merged this change in (with the Set implementation and some tests). @odaems thanks so much for finding and fixing this! I'll get a new release out on NPM in a few hours. |
|
You're welcome! Thanks for making this available in the first place! |
regex now matches lazy (using '?' after '*' in group) instead of greedy avoiding the need for result slicing and potential problems with multidigit line numbers
failed specs only get added once (especially important when using multiCapabilities)