Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0.0 #15

Merged
merged 181 commits into from
Jan 5, 2021
Merged

v2.0.0 #15

merged 181 commits into from
Jan 5, 2021

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Feb 7, 2020 •
edited
Loading

  • drop py2 compatibility
    • setup.py
      • classifiers
      • python_requires
    • syntax
    • document
  • fix conda install
  • fix logging
  • fix dependency versions
    • nibabel>=2.4.0 (was >=2.2.1, <=2.3.1)
  • tidy logging
    • sort out Cnt['VERBOSE']
    • linearise logic if verbose: log.info -> log.debug
    • replace log.error(...); sys.exit() -> raise
  • fix errors
  • test
  • use ninst as with NIMPA (os.platform/resources/cmake/cuda etc handling)
  • don't crash when re-running a reconstruction that was previously done with python2 (i.e. pre-existing niftyout/mumap-hdw)
    • migrated to npz from npy so no conflicts anyway here
  • depends on v2.0.0 NIMPA#4
  • fixes Is NIPET python3 compatible yet? #14
  • fixes export HMUDIR not respected #17
  • fixes No module named dinf #18

pjmark and others added 24 commits January 13, 2020 20:20
@pjmark
development of Python 3 version...
0923ce0
@pjmark
fixed a problem with gantry offset decoding in some LM files. added m…
fcc7209 
…issing updates for python 3
@casperdcl
revert mistakes
77c8348
@casperdcl
update requires to py3.4
d129c66
@casperdcl
update deps
ecf5004
@casperdcl
update installation instructions to py3
dd480a8
@pjmark
fixed the depreciated shuffle instructions in CUDA code.
884a045
@pjmark
removed unnecessary init code for mMR
7a361e2
@pjmark
added transaxial I/O functionality for further developemnt
3bccbbe
@pjmark
additional development for the transaxial projector
73edc48
@pjmark
modified put_gaps function to allow any number of sionograms.
844422c
@pjmark
fixed dev bug for put_gaps
8df0d49
@pjmark
fixed bug for the compute capability of 7.5--unpredicatable projectio…
229c804 
…n results. fixed also PVC recon in pipe.py.
@pjmark
fixed bugs when obtaining hardawre and normalisation parameters from …
9092e77 
…DICOM headers (mu-map and norm)
@pjmark
moved scatter crystal definitions to mmrsct.py
98ef717
@pjmark
moved scatter definitions to Python script mmrsct.py and resources.py…
aab0743 
… and then keeping them in synch with the sct.h
@pjmark
corrected/fixed recon with PVC for Python 3
83f224d
@pjmark
Merge branch 'dev2' of github.com:pjmark/NIPET into dev2
40c0a49
@pjmark
fixed extraction of table offset from DICOM
c2f031c
@pjmark
corrected pct mu-map generation in the older method. also moved the d…
d3ce3aa 
…efinitions of LM properites to scnner specific file from def.h
@casperdcl
fix and tidy install prompt
8316cf3
@casperdcl
fix conda multienv
c960fc5
@casperdcl
silly error fix
c6087f5
@casperdcl
major undefined fixes
c996745
@casperdcl casperdcl marked this pull request as ready for review January 5, 2021 02:59
@casperdcl casperdcl merged commit d27b3d2 into master Jan 5, 2021
@casperdcl casperdcl deleted the dev2 branch January 5, 2021 02:59
@casperdcl
Copy link
Member Author

/tag v2.0.0 d27b3d2

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjmark pjmark

@casperdcl casperdcl

Labels
enhancement framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No module named dinf export HMUDIR not respected Is NIPET python3 compatible yet?
4 participants
@casperdcl @codecov-io @pjmark @davecash75