Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Convert flag constants to [Flags] enums, where appropriate #10

Open
NightOwl888 opened this issue Sep 30, 2019 · 1 comment
Open

API: Convert flag constants to [Flags] enums, where appropriate #10

NightOwl888 opened this issue Sep 30, 2019 · 1 comment
Labels
design is:enhancement New feature or request pri:high up for grabs This issue is open to be worked on by anyone
Milestone
beta

Comments

@NightOwl888
Copy link
Owner

Much analysis must be done to ensure that the APIs contain all possible enums so all supported flags parameters can be passed, possibly by adding parameters for multiple enums.

This has already been done on the Normalizer class, but there are still other classes that use an int for flags which can accept a wide range of options. We don't necessarily need to make this any more than cosmetic - the values of the [Flags] enum values can remain the same as the constants that are being used now.
@NightOwl888 NightOwl888 added is:enhancement New feature or request up for grabs This issue is open to be worked on by anyone pri:high design labels Sep 30, 2019
@NightOwl888 NightOwl888 added this to the Beta Launch milestone Sep 30, 2019
NightOwl888 added a commit that referenced this issue Oct 11, 2019
@NightOwl888
ICU4N.Impl.UCharacterProperty: Eliminated public constants and made U…
4d2d8d5 
…PropertySource enum (#10, #11)
NightOwl888 added a commit that referenced this issue Oct 11, 2019
@NightOwl888
ICU4N.Impl.SortedSetRelation: Made constants internal and added Sorte…
95c7b9d 
…dSetFilter and SortedSetOperation enums to use instead of bit flags. (#10, #11)
@NightOwl888
Copy link
Owner Author

Known places where this still needs to happen:

  • TitleCase functionality (UChar, CaseMapImpl)
  • Trie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design is:enhancement New feature or request pri:high up for grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
beta
Development

No branches or pull requests
1 participant
@NightOwl888