Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename classes/interfaces/enums to conform with .NET conventions #21

Open
NightOwl888 opened this issue Oct 10, 2019 · 0 comments
Open

Rename classes/interfaces/enums to conform with .NET conventions #21

NightOwl888 opened this issue Oct 10, 2019 · 0 comments
Labels
awaits:discussion design is:enhancement New feature or request pri:high
Milestone
beta

Comments

@NightOwl888
Copy link
Owner

A few violations:

  1. Class names with acronyms should use Pascal casing for the acronym (i.e. IcuService instead of ICUService).
  2. Abbreviations (rather than acronyms) should be eliminated (i.e. Properties rather than Props).
  3. Need clarification on why some types are prefixed with U. Ideally, these would not be prefixed this way as well.
@NightOwl888 NightOwl888 added this to the beta milestone Oct 10, 2019
NightOwl888 added a commit that referenced this issue Oct 10, 2019
@NightOwl888
ICU4N.Impl.UCaseProps: Renamed UCaseProperties to conform with .NET c…
dd708c0 
…onventions (#21)
NightOwl888 added a commit that referenced this issue Oct 18, 2019
@NightOwl888
ICU4N.Text.CanonicalIterator: Renamed CanonicalEnumerator, added Move…
1c0bb56 
…Next() and Current, made Next() private (#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaits:discussion design is:enhancement New feature or request pri:high
Projects
None yet
Milestone
beta
Development

No branches or pull requests
1 participant
@NightOwl888