Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Add ReadOnlySpan<char> as a char sequence type to the T4 templates #54

Closed
NightOwl888 opened this issue Nov 17, 2023 · 0 comments · Fixed by #71
Closed

Task: Add ReadOnlySpan<char> as a char sequence type to the T4 templates #54

NightOwl888 opened this issue Nov 17, 2023 · 0 comments · Fixed by #71

Comments

@NightOwl888
Copy link
Owner

NightOwl888 commented Nov 17, 2023

We will need the ReadOnlySpan<char> overloads to optimize utility methods and avoid Substring() calls, which are extremely slow in .NET compared to Java. This requires updating the CodeGenerationSettings.xml file to include them and editing the T4 templates to correctly generate the overloads.

  • Methods that contain parameters for startIndex, endIndex, limit, length should omit these parameters and rely on the Slice() method of ReadOnlySpan<char> instead.

It would be best to wait until #40 is done before working on this task.

NightOwl888 added a commit that referenced this issue Feb 5, 2024
NightOwl888 added a commit that referenced this issue Feb 5, 2024
NightOwl888 added a commit that referenced this issue Feb 5, 2024
NightOwl888 added a commit that referenced this issue Feb 5, 2024
NightOwl888 added a commit that referenced this issue Feb 5, 2024
NightOwl888 added a commit that referenced this issue Feb 5, 2024
NightOwl888 added a commit that referenced this issue Sep 19, 2024
NightOwl888 added a commit that referenced this issue Sep 19, 2024
NightOwl888 added a commit that referenced this issue Sep 19, 2024
NightOwl888 added a commit that referenced this issue Sep 19, 2024
NightOwl888 added a commit that referenced this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant