SWEEP: Reviewed all catch blocks where Lucene uses MissingResourceExc…

…eption and converted them to use our IsMissingResourceException() extension method (see apache#446).
NightOwl888 · Apr 14, 2021 · 1ba90a8 · 1ba90a8
1 parent cc4a313
commit 1ba90a8
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/Lucene.Net.QueryParser/Flexible/Messages/NLS.cs b/src/Lucene.Net.QueryParser/Flexible/Messages/NLS.cs
@@ -147,9 +147,7 @@ private static string GetResourceBundleObject(string messageKey, CultureInfo loc
                         if (obj != null)
                             return obj;
                     }
-#pragma warning disable 168
-                    catch (MissingManifestResourceException e)
-#pragma warning restore 168
+                    catch (Exception e) when (e.IsMissingResourceException())
                     {
                         // just continue it might be on the next resource bundle
                     }
@@ -209,7 +207,7 @@ private static void ValidateMessage(string key, Type clazz)
                     }
                 }
             }
-            catch (MissingManifestResourceException) // LUCENENET: IDE0059: Remove unnecessary value assignment
+            catch (Exception e) when (e.IsMissingResourceException())
             {
                 //System.err.println("WARN: Message with key:" + key + " and locale: "
                 //    + Locale.getDefault() + " not found.");