Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opennlp dotnet core support mavenreference #27

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Opennlp dotnet core support mavenreference #27

wants to merge 27 commits into from

Conversation

NightOwl888
Copy link
Owner

No description provided.

@github-actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

@NightOwl888 NightOwl888 force-pushed the opennlp-dotnet-core-support-mavenreference branch from 912bc93 to fd152f1 Compare January 12, 2024 04:44
@NightOwl888 NightOwl888 force-pushed the opennlp-dotnet-core-support-mavenreference branch from fd152f1 to 99c421a Compare January 12, 2024 04:50
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

@NightOwl888 NightOwl888 force-pushed the opennlp-dotnet-core-support-mavenreference branch from 99c421a to 7deafeb Compare January 12, 2024 19:28
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

2 similar comments
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

@NightOwl888 NightOwl888 force-pushed the opennlp-dotnet-core-support-mavenreference branch from e7082f0 to 81ddf2c Compare January 13, 2024 12:52
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

laimis and others added 18 commits January 20, 2024 16:05
@laimis @NightOwl888
upgrade targets to target .net core 6, in addition to .net framework
3a5e5dd
@laimis @NightOwl888
update net 4.6 version
87fd563
@NightOwl888
Lucene.Net.Tests.OpenNLP: Patched IDE behavior to use net48 when net4…
93dbe5f 
…61 is selected and net7.0 when net5.0 is selected. In CI, we set IsTestProject=false and IsPublishable=false to skip these tests.
@NightOwl888
publish-test-results-for-test-projects.yml: Added support for net7.0 …
67260bb 
…and net6.0 for Lucene.Net.Tests.Analysis.OpenNLP tests.
@NightOwl888
.github/workflows: Regenerated to add net7.0 as a test framework for …
4495865 
…Lucene.Net.Tests.Analysis.OpenNLP
@NightOwl888
.build/dependencies.props: Upgrade System.Memory to 4.5.5 to match IK…
d2e4503 
…VM 8.2.0
@NightOwl888
.build/dependencies.props: Bumped System.Runtime.CompilerServices.Uns…
98dc38e 
…afe to 6.0.0 to match IKVM 8.5.0
@NightOwl888
Lucene.Net.csproj: Added direct dependency on System.Runtime.Compiler…
fbeeb02 
…Services.Unsafe for netstandard2.0 and net462 to ensure the version will work with any combination of Lucene.Net components. This is a transitive dependency in a few 3rd party DLLs, but there may be version conflicts if this isn't done on .NET Framework.
@NightOwl888
Lucene.Net.Facet.csproj: Added explicit dependency on System.Memory f…
0155ec6 
…or netstandard2.0 and net462, since it is being used in Lucene.Net.Facet.
@NightOwl888
Lucene.Net.TestFramework.csproj: Added dependency on System.Text.Json…
af204a1 
… to pin the version so it matches the reference of IKVM 8.5.0 (6.0.6).
@laimis @NightOwl888
upgrade targets to target .net core 6, in addition to .net framework
47f7608
@NightOwl888
Lucene.Net.Analysis.OpenNLP.csproj, .build/dependencies.props: Change…
4812657 
…d to use <MavenReference> to build opennlp-tools instead of using the pre-built OpenNLP.NET NuGet package.
@NightOwl888
.build/dependencies.props: bumped IKVM to 8.7.3 and IKVM.Maven.Sdk to…
ab84c28 
… 1.6.7
@NightOwl888
Lucene.Net.Analysis.OpenNLP.csproj: Removed duplicate TargetFramework…
fedcb53 
…s declaration
@NightOwl888
Lucene.Net.Analysis.OpenNLP: Changed target from net462 > net472, the…
3a39a6d 
… minimum supported by IKVM.
@NightOwl888
Directory.Build.targets: Updated FEATURE_OPENNLP to be available on .…
64f6c8d 
…NET Core
@NightOwl888
Lucene.Net.Tests.AllProjects: Updated references so we can successful…
0c25237 
…ly compile with IKVM in the mix, both on .NET Framework and .NET Core
@NightOwl888
.build/dependencies.props: Added OpenNLP MavenReference version so it…
5dd48e9 
… can be managed with the other packages
@NightOwl888
Lucene.Net.Analysis.OpenNLP: Added Maven dependency on org.osgi.core …
57df67c 
…to eliminate build warnings (at least 1 type is referenced in opennlp-tools)
@NightOwl888 NightOwl888 force-pushed the opennlp-dotnet-core-support-mavenreference branch from bfbe2e7 to 57df67c Compare January 20, 2024 09:06
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

@NightOwl888
Lucene.Net.Analysis.OpenNLP: For now, making net472 conditional based…
95891bd 
… on Windows due to lack of non-Windows build support in IKVM 8.7.3 (see: ikvmnet/ikvm-maven#49).
@github-actions GitHub Actions
Copy link

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

@NightOwl888
.build/dependencies.props: Reverted back to OpenNLP 1.9.1 because of …
944d8c7 
…build issues with opennlp-uima on 1.9.4. This aligns with Lucene 8.2.0.
@NightOwl888
publish-nuget-packages.yml: Remove forward slash
a334143
@NightOwl888
.build/dependencies.props: Bumped IKVM to 8.7.5
2a7bbc9
@NightOwl888
Lucene.Net.Analysis.OpenNLP/overview.md: Added missing docs from Luce…
e742bbb 
…ne and link to MavenReference demo. Fixes apache#890.
@NightOwl888
FEATURE: Lucene.Net.Analysis.Miscellaneous: Added TypeAsSynonymFilter…
79d4610 
… from Lucene 8.2.0 because it is called out in the docs as part of the process of configuring Lucene.Net.Analysis.OpenNLP. Changed CannedTokenStream to set ITypeAttribute.Type because it is required by the tests for TypeAsSynonymFilter.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

@NightOwl888
Lucene.Net.Analysis.Miscellaneous.TestTypeAsSynonymFilterFactory: Add…
4e73b61 
…ed comment with lucene version compatibility level (to indicate we ported it from Lucene 8.2.0)
@NightOwl888
Lucene.Net.Analysis.OpenNLP.overview.md: Corrected information about …
32d5cc9 
…which filters are included in the package (there is no NER filter in the box)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

⚠️ IMPORTANT: This PR may contain changes to dependency versions. The GitHub Actions test runner is not set up to detect dependency version conflicts between projects. To ensure the changes do not cause dependency conflicts, run the tests for these changes in Azure DevOps before accepting this pull request. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NightOwl888 @laimis