[WIP] Custom Symbol/Library loading logic #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nihlus
requested changes
Jun 19, 2019
Nihlus
requested changes
Jun 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 89.21% 89.46% +0.25%
==========================================
Files 108 109 +1
Lines 5172 5230 +58
Branches 444 445 +1
==========================================
+ Hits 4614 4679 +65
+ Misses 552 545 -7
Partials 6 6
Continue to review full report at Codecov.
|
Nihlus
requested changes
Jun 22, 2019
Nihlus
reviewed
Jun 22, 2019
Nihlus
approved these changes
Jun 22, 2019
Also adds beginning support infrastructure for custom library and symbol loading logic
A bunch of changes requested by the original dev
Added needed using and removed unnecessary property from NativeLibraryBase
Nihlus
requested changes
Jun 30, 2019
AdvancedDLSupport.Tests/Tests/Integration/CustomLoadingLogicTests.cs
Outdated
Show resolved
Hide resolved
Nihlus
reviewed
Jun 30, 2019
| @@ -57,7 +58,7 @@ public abstract class PlatformLoaderBase : IPlatformLoader | |||
| /// <returns>A platform loader for the current platform..</returns> | |||
| /// <exception cref="PlatformNotSupportedException">Thrown if the current platform is not supported.</exception> | |||
| [PublicAPI, NotNull, Pure] | |||
| public static IPlatformLoader SelectPlatformLoader() | |||
| private static IPlatformLoader SelectPlatformLoader() | |||
There was a problem hiding this comment.
Note to self: run an attribute cleanup sometime in the future.
Nihlus
approved these changes
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the ability for library users to add user loading logic to both library and library symbol loading.
Unfortunately, this is currently untested, Windows tests won't compile on my current setup
With these changes, it is possible to support API's like OpenGL and Vulkan because they export methods to look up the rest of their API's.