Change parseEntity to not wrap errors thrown by Decoders and Decodables.
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles in a `ParserError`. This allows the decoding process to report error conditions discovered in the JSON (e.g. embedded error codes) as something other than parsing errors. Added Decoder and Decodable tests to validate that custom errors can be caught as expected.
cnoon
requested changes
Aug 29, 2017
| @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| #### 2.x Releases | |||
|
|
|||
| * `2.2.x` Releases = [2.2.0](#220) | [2.2.1](#221) | |||
| * `2.2.x` Releases = [2.2.0](#220) | [2.2.1](#221) | [2.2.2](#222) | |||
There was a problem hiding this comment.
Let's revert this since there's going to be another PR going into 2.2.2.
| ## [2.2.2](https://github.com/Nike-Inc/Elevate/releases/tag/2.2.2) | ||
|
|
||
| Released on 2017-06-22. All issues associated with this milestone can be found using this | ||
| [filter](https://github.com/Nike-Inc/Elevate/milestone/5?closed=1). |
There was a problem hiding this comment.
Let's switch this over to master and add a commit message for these changes.
| @@ -43,12 +43,15 @@ public class Parser { | |||
| /// - closure: Defines the property list for the parser via the passed in `Schema` instance. | |||
| /// | |||
| /// - Returns: The parsed entity as a Dictionary. | |||
| /// | |||
| /// - Throws: `ParserError` for parsing related errors or `Error`s thrown by custom `Decodable` and `Decoder` implementations. | |||
| @@ -60,6 +63,8 @@ public class Parser { | |||
| } | |||
| } | |||
|
|
|||
| result = try parseEntity(json: json, closure: closure) | |||
There was a problem hiding this comment.
I think we can just get rid of the do-catch here.
| XCTAssertEqual(error.code, 42, "Error code did not match expected value.") | ||
| } catch { | ||
| XCTFail("Parser error was of incorrect type.") | ||
|
|
There was a problem hiding this comment.
Should switch over to using the XCTAssertThrowsError APIs here.
| XCTAssertEqual(error.code, 42, "Error code did not match expected value.") | ||
| } catch { | ||
| XCTFail("Parser error was of incorrect type.") | ||
|
|
There was a problem hiding this comment.
Should switch over to using the XCTAssertThrowsError APIs here.
|
I made all the changes suggested above and pushed them directly into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
parseEntityto not wrap errors thrown by Decoders and Decodables in aParserError.This allows the decoding process to report error conditions discovered in the JSON (e.g. embedded error codes) as something other than parsing errors.
Added Decoder and Decodable tests to validate that custom errors can be caught as expected.