Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support arbitrary delimiters in acc-role profile names #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markjreed
Copy link

@markjreed markjreed commented Sep 5, 2024

Description

If the cred_profile configuration parameter has the form "accXrole" for any character X, it is treated as "acc-role" with X as the delimiter between account and role in the generated profile name.

Related Issue

#474

Motivation and Context

See the issue.

How Has This Been Tested?

Added two new tests, one with a colon and resolve_alias true, the other with a slash and resolve_alias false.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    Technically will break if anyone is using a literal profile name that fits the pattern, e.g. 'acc@role'

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant