Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add SCD2 delta writer #4

Merged
merged 18 commits into from
May 23, 2024
Merged

[FEATURE] Add SCD2 delta writer #4

merged 18 commits into from
May 23, 2024

Conversation

mikita-sakalouski
Copy link
Contributor

Description

Delta supports ACID transaction which means we can support slow changing dimension type- 2 (SCD2) changes as well.

Related Issue

#1

Motivation and Context

Simple way to perform SCD2 dimensions

How Has This Been Tested?

Test have been added

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mikita-sakalouski mikita-sakalouski self-assigned this May 22, 2024
@mikita-sakalouski mikita-sakalouski linked an issue May 22, 2024 that may be closed by this pull request
[FEATURE] Add SCD2 Delta Writer #1
Closed
dannymeijer
dannymeijer approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@dannymeijer dannymeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things. Looks good mate!

.github/workflows/test.yaml Show resolved Hide resolved
koheesio/steps/step.py Outdated Show resolved Hide resolved
koheesio/steps/writers/delta/__init__.py Outdated Show resolved Hide resolved
koheesio/steps/writers/delta/utils.py Outdated Show resolved Hide resolved
@mikita-sakalouski mikita-sakalouski merged commit 2811ff0 into main May 23, 2024
8 checks passed
@mikita-sakalouski mikita-sakalouski deleted the feat/1-add-scd2-delta-writer branch May 23, 2024 11:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannymeijer dannymeijer dannymeijer approved these changes

Assignees

@mikita-sakalouski mikita-sakalouski

Labels
None yet
Projects
Koheesio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add SCD2 Delta Writer
2 participants
@mikita-sakalouski @dannymeijer