Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] - Updates to CONTRIBUTING #55

Merged
merged 3 commits into from
Sep 2, 2024
Merged

[Documentation] - Updates to CONTRIBUTING #55

merged 3 commits into from
Sep 2, 2024

Conversation

riccamini
Copy link
Contributor

Updates to CONTRIBUTING

Description

  • removed poetry references
  • updated make command to run tests

Related Issue

#53

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@riccamini riccamini requested a review from a team as a code owner July 9, 2024 15:14
pariksheet
pariksheet approved these changes Aug 30, 2024
View reviewed changes
Copy link

@pariksheet pariksheet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. LGTM

@dannymeijer dannymeijer merged commit 5819ed9 into Nike-Inc:main Sep 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pariksheet pariksheet pariksheet approved these changes

@dannymeijer dannymeijer dannymeijer approved these changes

Assignees

@riccamini riccamini

Labels
None yet
Projects
Koheesio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riccamini @pariksheet @dannymeijer