Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Backup' is disabled, after too many attempt just close the fingerprint modal #14

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

sabariferin
Copy link

@sabariferin sabariferin commented Mar 13, 2017

Setting 'use backup' as optional has been implemented in ionic-native.
ref: danielsogl/awesome-cordova-plugins#1158

If the "Backup" option is disabled and the user tried too many fingerprint attempts wrongly. It's showing "Backup" screen(pattern lock screen) to confirm the device to unlock. Expected result is the fingerprint modal should close.

Copy link
Owner

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@NiklasMerz NiklasMerz merged commit a79bf4c into NiklasMerz:master Mar 13, 2017
@NiklasMerz
Copy link
Owner

@sabariferin Thank you very much for doing this and adding the option to ionic-native. New plugin version is available on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants