Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for new bevy breaking changes #165

Merged
merged 4 commits into from
Jul 17, 2022
Merged

Update for new bevy breaking changes #165

merged 4 commits into from
Jul 17, 2022

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Jul 12, 2022 •
edited
Loading

This fixes recent breakage and makes all examples work again.

@Nilirad
Copy link
Owner

Nilirad commented Jul 12, 2022

Thanks, I'll test it next week, as soon as I have access to a PC.

@Nilirad Nilirad self-requested a review July 12, 2022 20:26
@rparrett rparrett changed the title Fix extract system not using new Extract SystemParam Update for new bevy breaking changes Jul 16, 2022
@rparrett
Copy link
Contributor Author

rparrett commented Jul 16, 2022 •
edited
Loading

Updated this for additional breaking changes.

Note: svg example is currently broken and I'm not sure if it's a bevy issue yet or if it needs to be fixed up here. See bevyengine/bevy#5334.

Nilirad
Nilirad approved these changes Jul 17, 2022
View reviewed changes
Copy link
Owner

@Nilirad Nilirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK, even the svg example. Thank you!!

@Nilirad Nilirad merged commit 33c5e99 into Nilirad:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nilirad Nilirad Nilirad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rparrett @Nilirad