Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CamelCase template component references with kebab-case #35

Closed
NiloCK opened this issue Aug 6, 2018 · 2 comments
Closed

Replace CamelCase template component references with kebab-case #35

NiloCK opened this issue Aug 6, 2018 · 2 comments

Comments

@NiloCK
Copy link
Owner

NiloCK commented Aug 6, 2018

Replace eg: <UserLogin /> with <user-login /> throughout the project. For reasons unknown to me, this helps VSCode track component definitions, etc.

NiloCK added a commit that referenced this issue Aug 8, 2018
NiloCK added a commit that referenced this issue Aug 8, 2018
@NiloCK
Copy link
Owner Author

NiloCK commented Aug 8, 2018

This hasn't had the desired effect. Possible difference is:

  • App.vue (which allows for 'go to definition') is defined w/
export default {
  name: 'App',
  components: {
    UserLoginAndRegistrationContainer,
    SnackbarService
  },
  data() {
    return {
      clipped: false,
      drawer: true,
      fixed: false,
      items: [
        {
          icon: 'home',
          title: 'Home'
        },
        {
          icon: 'school',
          title: 'Study'
        },
        {
          icon: 'add_to_queue',
          title: 'Edit'
        }
      ],
      miniVariant: false,
      right: true,
      rightDrawer: false,
      title: 'Skuilder'
    };
  }
};
  • Where the files that don't allow goto-def are class components:
@Component({
  components: {
    DataInputForm,
    ComponentRegistration
  }
})
export default class CourseEditor extends Vue {
  @Prop() public course: string;
  public registeredDataShapes: DataShape[] = [];
  public dataShapes: DataShape[] = [];
  public selectedShape: string = '';
  private loading: boolean = true;
  private editingMode: boolean = true;

// ...

@NiloCK NiloCK closed this as completed Aug 8, 2018
@NiloCK
Copy link
Owner Author

NiloCK commented Aug 10, 2018

Above suspicion was correct. Bug filed w/ vetur at vuejs/vetur#864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant