Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix fillin mixing #563

Merged
merged 2 commits into from
Jan 30, 2025
Merged

hotfix fillin mixing #563

merged 2 commits into from
Jan 30, 2025

Conversation

NiloCK
Copy link
Owner

@NiloCK NiloCK commented Jan 30, 2025

PR fixes (I think) a tricky issue where fill-in-the-blank question with multiple choice options was incorrectly reshuffling its options after each answer attempt.

Hypothesis: This occurred because a watchEffect was reacting to ELO score changes that happen after each answer.

Fix: replaced watchEffect with a more specific watch that only triggers on data changes, preventing unwanted reshuffling while maintaining the component's ability to initialize properly and respond to actual content updates. The original behavior was confusing for users and could make correct answers unavailable if they landed in a previously-selected position.

  • remove unused answer parse method...
  • specify watcher to only the data prop...

possibly useful for parsing multi-blanks, but they are not yet in use
to stop re-rendering when a user's ELO changes due to registering
question attempts
@NiloCK NiloCK merged commit 2d1f20a into master Jan 30, 2025
1 check passed
@NiloCK NiloCK deleted the hotfix-fillin-mixing branch January 30, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant