Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore unknown chrome output, like internal errors, warnings, etc. #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ignore unknown chrome output, like internal errors, warnings, etc. #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/core/chrome.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,7 @@ proc startChrome*(portNo: int; userDataDir: string; headless: HeadlessMode;
"note: you can leave your normal browser window/session alone.")
elif line == "": continue
else:
process.terminate()
process.close()
raise newException(ProcessError, "unexpected output from Chrome: " & line)
discard
if result.cdpEndPoint == "":
if process.running():
process.terminate()
Expand Down