Use generated client for set_key_certificate #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we manually implemented the PUT /keys/{KeyID}/cert API call
because it used content types that were not supported by the generated
API client. Now it only accepts application/octet-stream, so we can use
the generated client instead of manually performing the request.
robin-nitrokey
requested review from
daringer,
szszszsz,
sosthene-nitrokey and
q-nk
q-nk
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we manually implemented the PUT /keys/{KeyID}/cert API call because it used content types that were not supported by the generated API client. Now it only accepts application/octet-stream, so we can use the generated client instead of manually performing the request.