Fix compilation warnings (1)

Fixes #235

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>

src/hotpslot.h

@@ -39,11 +39,11 @@ class OTPSlot {
     ~OTPSlot(){
       volatile char* p;
       p = slotName;
-      for (int i = 0; i < sizeof(slotName); ++i) {
+      for (uint64_t i = 0; i < sizeof(slotName); ++i) {
         p[i] = 0;
       }
       p = secret;
-      for (int i = 0; i < sizeof(secret); ++i) {
+      for (uint64_t i = 0; i < sizeof(secret); ++i) {
         p[i] = 0;
       }
       slotNumber = 0;

src/ui/mainwindow.cpp

@@ -48,12 +48,16 @@ using nm = nitrokey::NitrokeyManager;
 static const QString communication_error_message = QApplication::tr("Communication error. Please reinsert the device.");
 
 
-MainWindow::MainWindow(QWidget *parent)
-    : QMainWindow(parent), ui(new Ui::MainWindow),
-       clipboard(this), auth_admin(this, Authentication::Type::ADMIN),
-      auth_user(this, Authentication::Type::USER), storage(this, &auth_admin, &auth_user),
-      tray(this, false, true, &storage),
-      HOTP_SlotCount(HOTP_SLOT_COUNT), TOTP_SlotCount(TOTP_SLOT_COUNT)
+MainWindow::MainWindow(QWidget *parent):
+    QMainWindow(parent),
+    ui(new Ui::MainWindow),
+    clipboard(this),
+    auth_admin(this, Authentication::Type::ADMIN),
+    auth_user(this, Authentication::Type::USER),
+    storage(this, &auth_admin, &auth_user),
+    tray(this, false, true, &storage),
+    HOTP_SlotCount(HOTP_SLOT_COUNT),
+    TOTP_SlotCount(TOTP_SLOT_COUNT)
 {
 
   progress_window = std::make_shared<Stick20ResponseDialog>();

src/ui/mainwindow.h

@@ -56,24 +56,23 @@ public :
 private:
   Q_DISABLE_COPY(MainWindow);
 
+  Ui::MainWindow *ui;
+  Clipboard clipboard;
   Authentication auth_admin;
   Authentication auth_user;
   StorageActions storage;
   Tray tray;
-  Clipboard clipboard;
+  const unsigned char HOTP_SlotCount;
+  const unsigned char TOTP_SlotCount;
+
 
   bool validate_secret(const char *secret) const;
   void initialTimeReset();
   QMutex check_connection_mutex;
   QString nkpro_user_PIN;
-
   void startDebug();
   QTimer *keepDeviceOnlineTimer;
 
-  Ui::MainWindow *ui;
-
-  const unsigned char HOTP_SlotCount;
-  const unsigned char TOTP_SlotCount;
 
   bool PWS_Access = false;
   const int PWS_CreatePWSize = 20;

src/ui/pindialog.cpp

@@ -26,8 +26,9 @@
 
 #define LOCAL_PASSWORD_SIZE 40 // Todo make define global
 
-PinDialog::PinDialog(PinType pinType, QWidget *parent)
-    : _pinType(pinType), QDialog(parent)
+PinDialog::PinDialog(PinType pinType, QWidget *parent):
+    QDialog(parent),
+    _pinType(pinType)
 {
   ui = std::make_shared<Ui::PinDialog>();
   ui->setupUi(this);

src/ui/stick20changepassworddialog.cpp

@@ -26,8 +26,11 @@
 #include "src/core/ThreadWorker.h"
 using nm = nitrokey::NitrokeyManager;
 
-DialogChangePassword::DialogChangePassword(QWidget *parent, PasswordKind _kind)
-    : QDialog(parent), ui(new Ui::DialogChangePassword), kind(_kind) {
+DialogChangePassword::DialogChangePassword(QWidget *parent, PasswordKind _kind):
+    QDialog(parent),
+    ui(new Ui::DialogChangePassword),
+    kind(_kind)
+{
   ui->setupUi(this);
 
   ui->lineEdit_OldPW->setEchoMode(QLineEdit::Password);
@@ -50,7 +53,6 @@ DialogChangePassword::~DialogChangePassword() { delete ui; }
 
 void DialogChangePassword::UpdatePasswordRetry() {
   QString noTrialsLeft;
-  int retryCount = 99;
   // update password retry values
 
   switch (kind) {

src/ui/stick20changepassworddialog.h

@@ -56,8 +56,8 @@ private slots:
   void on_checkBox_clicked(bool checked);
 
 private:
-  PasswordKind kind;
   Ui::DialogChangePassword *ui;
+  PasswordKind kind;
   void _changePassword();
   void accept(void) override;
   void UpdatePasswordRetry(void);

src/ui/stick20debugdialog.cpp

@@ -142,7 +142,7 @@ DebugDialog::~DebugDialog() {
 *******************************************************************************/
 
 void DebugDialog::UpdateDebugText() {
-  static int nCallCounter = 0;
+//  static int nCallCounter = 0;
 
 //  if (TRUE == DebugingStick20PoolingActive) {
     // Send request