Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nitrokey App should be more accessible to screen reader users #9

Closed
heikofolkerts opened this issue Oct 3, 2015 · 11 comments
Closed

Nitrokey App should be more accessible to screen reader users #9

heikofolkerts opened this issue Oct 3, 2015 · 11 comments
Assignees
@szszszsz
Labels
enhancement
Milestone
1.0

Comments

@heikofolkerts
Copy link

I am using a screen reader such as NVDA http://www.nvda-project.org to access the contents of applications. The Nitrokey App is accessible to screenreaders to some extend, but there are some small things missing:

  • All controls in the dialogs should have the property "accessibleName" set to inform the screen reader user what the control will contain or do. In general this is the label attached to a edit field or list box etc. Since the code seems to be in QT5 setting the property is just a line of code for every control.
  • The order in which the controls get focus when using the tab key is restricted to just editable controls. It would be very helpful if the order will contain all (even read only controls) so that the tab key will visit every part of the dialog. When setting up one time passwords reading read only field contents is crutial. If including all controls in this tab order will disturbe non screen reader users then detection of an active screenreader or just a checkbox may help with this. AFAIK the order for tabbing is controlled by the property "tabIndex".
  • Controls that have a tooltip should also get the contents of that tool tip in the property "accessibleDescription".

Making the quite small changes mentioned above will enable blind people to fully use the nitro key. The nitrokey can then be used as alternate solution instead of the well known RSA keys that only have a smal display and are commonly used to do TOTP. So solving this issue may open up new doors for blind people.
@jans23 jans23 added this to the 0.6 milestone Aug 9, 2016
@szszszsz szszszsz modified the milestones: 0.6, 0.7 Nov 26, 2016
@jans23
Copy link
Member

jans23 commented Mar 2, 2017

@szszszsz Since you are reworking the GUI right now, perhaps you could consider this issue and suggested improvements. Thanks.

@szszszsz szszszsz self-assigned this Apr 5, 2017
szszszsz added a commit that referenced this issue Apr 6, 2017
@szszszsz
Accessibility: Hidden Volume
93ecb45 
Accessability: tab order in hidden volume form
Accessability: names and description in hidden volume setup form

Fixes #9

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Apr 7, 2017
@szszszsz
Accessibility: Hidden Volume
3a1140d 
Accessability: tab order in hidden volume form
Accessability: names and description in hidden volume setup form

Fixes #9

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Apr 7, 2017
@szszszsz
Accessibility: Hidden Volume
aef2516 
Accessability: tab order in hidden volume form
Accessability: names and description in hidden volume setup form

Fixes #9

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member

szszszsz commented Apr 7, 2017 •
edited
Loading

Hi!
Qt5 fortunately supports this out-of-the-box. However App's UI was not designed in the way it could done all work by itself. I had to 'only' rework tab order plus adding proper names and descriptions to changeable controls. I have added read-only labels to tab cycle whenever it could be done in not confusing way to non screen-reader user. On other case names and descriptions were added to fields directly so each one is easily identified. I hope you will be pleased with the results. Feedback is welcome.
All changes tested on Windows 8.1 with mentioned NVDA software.
Feature now staged in beta.3 branch. Issue will be closed when this will be merged to mainline.

@szszszsz szszszsz modified the milestones: 0.7, 1.0 Apr 7, 2017
@heikofolkerts
Copy link
Author

heikofolkerts commented Apr 12, 2017 via email

@szszszsz
Copy link
Member

Sure! We do not have artifacts on our CI build unfortunately.
I will add them to pre-release tag and link here. For which OS would you like the binaries?

@heikofolkerts
Copy link
Author

heikofolkerts commented Apr 14, 2017 via email

@szszszsz
Copy link
Member

OK! I will upload test binary in an hour.

@szszszsz
Copy link
Member

I have uploaded binaries to https://github.com/Nitrokey/nitrokey-app/releases/tag/v1.0-beta.3 .
Let me know how the test went.

@heikofolkerts
Copy link
Author

heikofolkerts commented Apr 17, 2017 via email

@szszszsz
Copy link
Member

szszszsz commented Apr 19, 2017 •
edited
Loading

  1. Do you mean PIN counters for instance? I will check that. I was sure all labels are accessible with <Tab> key.
  2. Could you share the model and firmware version of the device you have used? I would like to retest that.
  3. Nevertheless, a guard for invalid secret should be added and a warning should be shown.

@szszszsz szszszsz reopened this Apr 19, 2017
This was referenced Apr 19, 2017
Closed
Closed
@heikofolkerts
Copy link
Author

heikofolkerts commented Apr 20, 2017 via email •
edited by szszszsz
Loading

@szszszsz
Copy link
Member

OK! I guess this could be closed now. Thank you for testing and support!

szszszsz added a commit that referenced this issue Sep 11, 2017
@szszszsz
Merge pull request #9 from privacyidea/fix_counter_reset
c19dfe6 
Reset the HOTP counter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szszszsz szszszsz

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@jans23 @heikofolkerts @szszszsz