Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: weekly npins update #329

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore: weekly npins update #329

merged 1 commit into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automatic npins update performed by GitHub Actions

@fricklerhandwerk
Copy link
Collaborator

@RaitoBezarius it still doesn't fire the checks....

@Erethon
Copy link
Contributor

Erethon commented Nov 14, 2024

@RaitoBezarius it still doesn't fire the checks....

Technically the checks did run, the run is this one, but the run isn't linked to this PR so the checks aren't visible in the UI.

This happens for two reasons:

  1. The checks are triggered by this action, which is a workflow_dispatch and workflow dispatches are considered a "manual run", so they don't update PR information. Only ["pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_target", "push"] actions can link and update an action run to a PR.
  2. The reason checks aren't triggered by default is this issue. The tl;dr is that GitHub doesn't allow (most) actions to create further actions when using the default GITHUB_TOKEN. There are various workarounds we can use, I think going with the last one (GH App token) makes the most sense in our case.

@fricklerhandwerk
Copy link
Collaborator

fricklerhandwerk commented Nov 14, 2024

Created #357 to follow up

@fricklerhandwerk fricklerhandwerk merged commit e6e9b39 into main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants