dropEmptyInitThenConcatStringsSep: Allow it to drop items again

It's usually harmless, if it occurs at all.
NixOS · Jul 13, 2024 · 1c97718 · 1c97718
1 parent 6b2c277
commit 1c97718
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/libutil/util.hh b/src/libutil/util.hh
@@ -41,11 +41,13 @@ std::string dropEmptyInitThenConcatStringsSep(const std::string_view sep, const
 {
     size_t size = 0;
 
-    for (auto & i : ss) {
-        // Make sure we don't rely on the empty item ignoring behavior
-        assert(!i.empty());
-        break;
-    }
+    // TODO? remove to make sure we don't rely on the empty item ignoring behavior,
+    //       or just get rid of this function by understanding the remaining calls.
+    // for (auto & i : ss) {
+    //     // Make sure we don't rely on the empty item ignoring behavior
+    //     assert(!i.empty());
+    //     break;
+    // }
 
     // need a cast to string_view since this is also called with Symbols
     for (const auto & s : ss) size += sep.size() + std::string_view(s).size();