Skip to content

Commit

Permalink
Don’t create lockfiles with an invalid path name
Browse files Browse the repository at this point in the history
Store paths are only allowed to contain a limited subset of the
alphabet, which doesn’t include `!`. So don’t create lockfiles that
contain this `!` character as that would otherwise confuse (and break)
the gc.

Fix #5176
  • Loading branch information
thufschmitt committed Sep 2, 2021
1 parent c397184 commit 497225b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/libstore/build/derivation-goal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ void DerivationGoal::tryToBuild()
lockFiles.insert(worker.store.Store::toRealPath(*i.second.second));
else
lockFiles.insert(
worker.store.Store::toRealPath(drvPath) + "!" + i.first
worker.store.Store::toRealPath(drvPath) + "." + i.first
);
}
}
Expand Down

0 comments on commit 497225b

Please sign in to comment.