Proper parse and render functions for FileIngestionMethod and ContentAddressMethod
#10009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ContentAddressMethod` No outward facing behavior is changed. Older methods with same names that operate on on method + algo pair (for old-style `<method>:algo`) are renamed to `*WithAlgo`.) The functions are unit-tested in the same way the names for the hash algorithms are tested.
github-actions
bot
added
new-cli
Good to deduplicate the code.
github-actions
bot
added
the
fetching
thufschmitt
reviewed
Feb 14, 2024
Comment on lines
+25
to
+26
| default: | ||
| abort(); |
There was a problem hiding this comment.
Coming a bit late, but is that default necessary? I thought that enum structs could do some exhaustiveness checking.
There was a problem hiding this comment.
I don't think so https://gcc.gnu.org/wiki/VerboseDiagnostics#enum_switch
But @roberth dded a werror so that all variants must be mentioned even with a default:, which makes the default: less of a foot-gun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Needed for #9815
Context
No outward facing behavior is changed.
Older methods with same names that operate on on method + algo pair (for old-style
<method>:algo) are renamed to*WithAlgo.)The functions are unit-tested in the same way the names for the hash algorithms are tested.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.