Make outputHashAlgo accept "nar", stay in sync
#10021
Conversation
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
ca-type-names
branch
2 times, most recently
from
c21f04d
to
9d246ff
Compare
Ericson2314
force-pushed
the
ca-type-names
branch
from
9d246ff
to
08d293a
Compare
| if (s == "recursive") { | ||
| // back compat, new name is "nar" | ||
| ingestionMethod = FileIngestionMethod::Recursive; |
There was a problem hiding this comment.
Don't we instead want to accept `recursive as a file ingestion method for consistency?
There was a problem hiding this comment.
I am not sure what you mean, I think change ContentAddressMethod::parse so this one is accepted everywhere (e.g. the new CLI too)?
There was a problem hiding this comment.
I forget whether we discussed this before, but I do want to over time steer people to the new name (which is clearer) in the new CLI.
There was a problem hiding this comment.
(Also with git support, which I hope to merge very soon, NAR isn't the only "recursive" format anyways.)
Ericson2314
force-pushed
the
ca-type-names
branch
2 times, most recently
from
b84755a
to
1eb4c55
Compare
Ericson2314
force-pushed
the
ca-type-names
branch
from
1eb4c55
to
38a6c40
Compare
thufschmitt
added
the
idea approved
Ericson2314
force-pushed
the
ca-type-names
branch
from
38a6c40
to
feb993d
Compare
|
Discussed during the Nix maintainers meeting on 2024-02-28.
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-02-28-nix-team-meeting-129/40499/1 |
Ericson2314
force-pushed
the
ca-type-names
branch
from
feb993d
to
504b74f
Compare
Ericson2314
force-pushed
the
ca-type-names
branch
from
504b74f
to
ef055f4
Compare
This was part of approved PR NixOS#10021. Unfortunately that one is stalled on a peculiar Linux test timeout, so trying to get bits of it merged first to bisect failure.
Ericson2314
force-pushed
the
ca-type-names
branch
from
ef055f4
to
f96cb57
Compare
This was part of approved PR #10021. Unfortunately that one is stalled on a peculiar Linux test timeout, so trying to get bits of it merged first to bisect failure.
Now that we have a few things identifying content address methods by name, we should be consistent about it. Move up the `parseHashAlgoOpt` for tidiness too. Discussed this change for consistency's sake as part of NixOS#8876 Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Ericson2314
force-pushed
the
ca-type-names
branch
from
f96cb57
to
93d68e1
Compare
|
This would be a case where a release note becomes more valuable over time. |
Motivation
Now that we have a few things identifying content address methods by name, we should be consistent about it.
Move up the
parseHashAlgoOptfor tidiness too.Context
Discussed this change for consistency's sake as part of #8876
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.