nix: Fix haveInternet to check for proxy
#10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just for consistency with the rest
thufschmitt
approved these changes
Feb 23, 2024
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
`nix`: Fix `haveInternet` to check for proxy (cherry picked from commit accae60) Change-Id: I996dafdcd266f4bc5806386c86b19040120842bf
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
haveInternetshould check if a proxy is available. If it is, it must return true sonixcould function properly. See #10017 for more details.Context
Fixes: #10017
/etc/systemd/system/nix-daemon.service.d/override.confis used bynix-daemonand not necessarily bynix. Ifnixneeds to download something without going through the daemon, it can only be done if proxy environment variables are defined.haveProxyEnvironmentVariablescheck for these variables.Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.